hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Poepping <poe...@amazon.com>
Subject Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max
Date Wed, 15 Feb 2017 05:39:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56688/#review165645
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 3302 - 3303)
<https://reviews.apache.org/r/56688/#comment237514>

    Just to be more clear, maybe "(recommended > 1 for blobstore)"



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (lines 2123 - 2124)
<https://reviews.apache.org/r/56688/#comment237515>

    to avoid duplicating code, could we wrap this functionality in a helper method? then this
method could also detect if DEPRECATED_MAPRED_DFSCLIENT_PARALLELISM_MAX is being used, and
if so, log a WARN



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (lines 2989 - 2991)
<https://reviews.apache.org/r/56688/#comment237516>

    what if my maxThreads is 1000, but I only have one input path? weren't we going to add
a check to not create a too-large threadPool?


- Thomas Poepping


On Feb. 14, 2017, 10:58 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56688/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 10:58 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-15881
>     https://issues.apache.org/jira/browse/HIVE-15881
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Deprecates the use of mapred.dfsclient.parallelism.max, and instead use hive.exec.input.listing.max.threads
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0bff243f08188c98ffe16c6602f628412881fc66

>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java e81cbce3e333d44a4088c10491f399e92a505293

>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 5a9d83ca4890a68a63f8f6c145d30906a58c7e73

> 
> Diff: https://reviews.apache.org/r/56688/diff/
> 
> 
> Testing
> -------
> 
> Added tests to TestUtilities.
> Waiting for HiveQA
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message