hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daniel voros <daniel.vo...@gmail.com>
Subject Review Request 56541: HIVE-15833 Add unit tests for org.json usage on branch-1
Date Fri, 10 Feb 2017 12:35:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56541/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-15833
    https://issues.apache.org/jira/browse/HIVE-15833


Repository: hive-git


Description
-------

This adds test to all non-trivial usages of the org.json library.

The new tests also use org.json, but only to a minimal extent and only where it is necessary
to interact with the units under tests (e.g. when testing a method with a JSONObject attribute).
These usages should be trivial to replace when switching implementation.

In every other place, where org.json was not absolutely necessary, Jackson is used to interact
with (mostly to compare) JSON objects. Jackson was chosen over json-simple and gson, as it
is already a dependency of Hive and it's object mapping capabilities might come in handy when
switching implementation.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java fb12f7010fa62c7898849d11e96365c377b5f52a

  common/src/test/org/apache/hadoop/hive/common/jsonexplain/tez/TestOp.java PRE-CREATION 
  common/src/test/org/apache/hadoop/hive/common/jsonexplain/tez/TestStage.java PRE-CREATION

  common/src/test/org/apache/hadoop/hive/common/jsonexplain/tez/TestTezJsonParser.java PRE-CREATION

  common/src/test/org/apache/hadoop/hive/common/jsonexplain/tez/TestVertex.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 35c4cfc3d0fba09f3bfdcbb8a8264d71c2d52183

  ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java 53d169d290a4d7303ebeef3d183a93d82eca3f74

  ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java a4c5d0e5d4e809ec5b7be9694ac0ea53aa584118

  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExplainTask.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/hooks/TestATSHook.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestEximUtil.java 108f8e557165c525b1ebf18219292a3744b0e99f


Diff: https://reviews.apache.org/r/56541/diff/


Testing
-------


Thanks,

daniel voros


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message