hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergio Pena <sergio.p...@cloudera.com>
Subject Re: Review Request 56095: HIVE-15754 exchange partition is not generating notifications
Date Tue, 07 Feb 2017 20:49:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56095/#review164553
-----------------------------------------------------------



Thanks Nachiket, the patch looks good. Just a minior change to check for null and empty values
and this would good to go.


metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2991)
<https://reviews.apache.org/r/56095/#comment236322>

    Should we check table and partitions for null and empty values? I see this condition in
other methods that fire add partition events.


- Sergio Pena


On Jan. 30, 2017, 8:51 p.m., Nachiket Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56095/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 8:51 p.m.)
> 
> 
> Review request for hive and Mohit Sabharwal.
> 
> 
> Bugs: HIVE-15754
>     https://issues.apache.org/jira/browse/HIVE-15754
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15754 exchange partition is not generating notifications
> 
> exchange partition event is not generating notifications in notification_log.
> There should multiple events generated. one add_partition event and several drop_partition
events.
> for example:
> ALTER TABLE tab1 EXCHANGE PARTITION (part=1) WITH TABLE tab2;
> 
> There should be the following events:
> ADD_PARTITION on tab2 on partition (part=1)
> DROP_PARTITION on tab1 on partition (part=1)
> 
> 
> Diffs
> -----
> 
>   itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
640b567 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 13d0aab 
> 
> Diff: https://reviews.apache.org/r/56095/diff/
> 
> 
> Testing
> -------
> 
> o Added unit test cases.
> o Ran exchange partition queries and saw entired in notification_log.
> 
> 
> Thanks,
> 
> Nachiket Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message