Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0CA93200C17 for ; Fri, 27 Jan 2017 00:47:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0B251160B50; Thu, 26 Jan 2017 23:47:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5368C160B4C for ; Fri, 27 Jan 2017 00:47:10 +0100 (CET) Received: (qmail 52342 invoked by uid 500); 26 Jan 2017 23:47:09 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52328 invoked by uid 99); 26 Jan 2017 23:47:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 23:47:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 77177317C08; Thu, 26 Jan 2017 23:47:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7998550377619010410==" MIME-Version: 1.0 Subject: Re: Review Request 55898: HIVE-15698 Vectorization support for min/max/bloomfilter runtime filtering From: Jason Dere To: Matt McCline , Deepak Jaiswal Cc: hive , Jason Dere Date: Thu, 26 Jan 2017 23:47:07 -0000 Message-ID: <20170126234707.13409.91874@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jason Dere X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55898/ X-Sender: Jason Dere References: <20170125000342.13408.97891@reviews.apache.org> In-Reply-To: <20170125000342.13408.97891@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java X-ReviewBoard-Diff-For: ql/src/gen/vectorization/ExpressionTemplates/FilterColumnBetweenDynamicValue.txt X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilter.java X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/vectorized_dynamic_semijoin_reduction.q X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorInBloomFilterColDynamicValue.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilterMerge.java Reply-To: Jason Dere X-ReviewRequest-Repository: hive-git archived-at: Thu, 26 Jan 2017 23:47:11 -0000 --===============7998550377619010410== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55898/ ----------------------------------------------------------- (Updated Jan. 26, 2017, 11:47 p.m.) Review request for hive, Deepak Jaiswal and Matt McCline. Changes ------- Incorporating review feedback. Bugs: HIVE-15698 https://issues.apache.org/jira/browse/HIVE-15698 Repository: hive-git Description ------- Adds vectorized support for ExprNodeDynamicValue, BETWEEN() with DynamicValue, bloom_filter() aggregation function, and in_bloom_filter() Diffs (updated) ----- ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java e9fe8fa itests/src/test/resources/testconfiguration.properties e966959 ql/src/gen/vectorization/ExpressionTemplates/FilterColumnBetweenDynamicValue.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/FilterDecimalColumnBetween.txt d68edfa ql/src/gen/vectorization/ExpressionTemplates/FilterStringColumnBetween.txt e8049da ql/src/gen/vectorization/ExpressionTemplates/FilterTimestampColumnBetween.txt 4298d79 ql/src/gen/vectorization/ExpressionTemplates/FilterTruncStringColumnBetween.txt 94a174d ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java 7bbedf6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java 217af3f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFilterOperator.java 261246b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSelectOperator.java f7fec8f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java c887757 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java 8fca8a1 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorInBloomFilterColDynamicValue.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilter.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilterMerge.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java e3d9d7f ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBloomFilter.java fb9a140 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInBloomFilter.java 1b7de6c ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java 59cb31e ql/src/test/queries/clientpositive/vectorized_dynamic_semijoin_reduction.q PRE-CREATION ql/src/test/results/clientpositive/llap/mergejoin.q.out 4ec2a71 ql/src/test/results/clientpositive/llap/orc_llap.q.out 90055a5 ql/src/test/results/clientpositive/llap/vector_binary_join_groupby.q.out 9fbce7d ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 3d087b3 ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out PRE-CREATION ql/src/test/results/clientpositive/vector_binary_join_groupby.q.out 850278e storage-api/src/java/org/apache/hive/common/util/BloomFilter.java d44bba8 storage-api/src/test/org/apache/hive/common/util/TestBloomFilter.java 63c7050 Diff: https://reviews.apache.org/r/55898/diff/ Testing ------- qtests Thanks, Jason Dere --===============7998550377619010410==--