Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8E366200BFE for ; Mon, 16 Jan 2017 11:55:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8CB29160B30; Mon, 16 Jan 2017 10:55:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6662160B22 for ; Mon, 16 Jan 2017 11:55:03 +0100 (CET) Received: (qmail 95264 invoked by uid 500); 16 Jan 2017 10:55:02 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 95251 invoked by uid 99); 16 Jan 2017 10:55:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jan 2017 10:55:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F3BC31492C; Mon, 16 Jan 2017 10:55:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6939841355146625096==" MIME-Version: 1.0 Subject: Re: Review Request 53619: HIVE-15161 migrate ColumnStats to use jackson From: Zoltan Haindrich To: pengcheng xiong , hive , Zoltan Haindrich Date: Mon, 16 Jan 2017 10:55:02 -0000 Message-ID: <20170116105502.28414.82529@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zoltan Haindrich X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53619/ X-Sender: Zoltan Haindrich References: <20161209131459.15025.34167@reviews.apache.org> In-Reply-To: <20161209131459.15025.34167@reviews.apache.org> Reply-To: Zoltan Haindrich X-ReviewRequest-Repository: hive-git archived-at: Mon, 16 Jan 2017 10:55:04 -0000 --===============6939841355146625096== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53619/ ----------------------------------------------------------- (Updated Jan. 16, 2017, 10:55 a.m.) Review request for hive. Changes ------- addressed comments ; rbt#2 is patch#5 on jira Bugs: HIVE-15161 https://issues.apache.org/jira/browse/HIVE-15161 Repository: hive-git Description ------- * json.org has license issues * jackson can provide a fully compatible alternative to it * there are a few flakiness issues caused by the order of the map entries of the columns...this can be addressed, org.json api was unfriendly in this manner ;) * fully backward compatible change Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 25c7508f51662773e913a176bee7c8bd223202d4 common/src/test/org/apache/hadoop/hive/common/TestStatsSetupConst.java 7a7ad424a8e53ed89c79592ced86c7c38eaf4e04 Diff: https://reviews.apache.org/r/53619/diff/ Testing ------- added unit test Thanks, Zoltan Haindrich --===============6939841355146625096==--