Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C5519200C02 for ; Fri, 6 Jan 2017 03:53:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3F7E160B42; Fri, 6 Jan 2017 02:53:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3058160B33 for ; Fri, 6 Jan 2017 03:53:53 +0100 (CET) Received: (qmail 4588 invoked by uid 500); 6 Jan 2017 02:53:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 4570 invoked by uid 99); 6 Jan 2017 02:53:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jan 2017 02:53:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4F33B3115B1; Fri, 6 Jan 2017 02:53:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2756048581432864665==" MIME-Version: 1.0 Subject: Re: Review Request 55247: LLAP: use LLAP cache for non-columnar formats in a somewhat general way From: Sergey Shelukhin To: Gopal V , j.prasanth.j@gmail.com, Siddharth Seth Cc: Sergey Shelukhin , hive Date: Fri, 06 Jan 2017 02:53:51 -0000 Message-ID: <20170106025351.13569.70842@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sergey Shelukhin X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55247/ X-Sender: Sergey Shelukhin References: <20170106022948.13478.20701@reviews.apache.org> In-Reply-To: <20170106022948.13478.20701@reviews.apache.org> X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/cache/FileCacheCleanupThread.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerStripeMetadata.java X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/llap_text.q X-ReviewBoard-Diff-For: data/files/over10k.gz X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/cache/FileCache.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/LineRrOffsetReader.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/PassThruOffsetReader.java X-ReviewBoard-Diff-For: llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerFileMetadata.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap_text.q.out Reply-To: Sergey Shelukhin X-ReviewRequest-Repository: hive-git archived-at: Fri, 06 Jan 2017 02:53:55 -0000 --===============2756048581432864665== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55247/#review160668 ----------------------------------------------------------- llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/LineRrOffsetReader.java (line 30) wrong - Sergey Shelukhin On Jan. 6, 2017, 2:29 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55247/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 2:29 a.m.) > > > Review request for hive, Gopal V, Prasanth_J, and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47db0c0 > data/files/over10k.gz PRE-CREATION > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIo.java d82757f > llap-server/src/java/org/apache/hadoop/hive/llap/IncrementalObjectSizeEstimator.java 3efbcc2 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java d9d407d > llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java b6fd3e3 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/FileCache.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/FileCacheCleanupThread.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java d1a961c > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java ea458ca > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java 290624d > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 8048624 > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java db86296 > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java 6b54b30 > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java 2e9b9c3 > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 29f1ba8 > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java 4e1b851 > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/LineRrOffsetReader.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/PassThruOffsetReader.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerFileMetadata.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerStripeMetadata.java PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java 70cba05 > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcMetadataCache.java 3f4f43b > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 6f0b9ff > orc/src/java/org/apache/orc/OrcUtils.java dc83b9c > orc/src/java/org/apache/orc/impl/PhysicalWriter.java 83742e4 > orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 975804b > orc/src/java/org/apache/orc/impl/TreeReaderFactory.java 3ddafba > orc/src/java/org/apache/orc/impl/WriterImpl.java 518a5f7 > ql/src/java/org/apache/hadoop/hive/llap/DebugUtils.java 3d81e43 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 601ad08 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 0161c20 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java 323419c > ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java ba25573 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 94fcd60 > ql/src/java/org/apache/hadoop/hive/ql/io/LlapWrappableInputFormatInterface.java 66e1f90 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 361901e > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 075c3b4 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/CacheChunk.java 2325140 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java d5f5f9d > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/StreamUtils.java cef765c > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java 09e4a47 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java e1fb8fb > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 2a99274 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPartitionDesc.java 7bf70c6 > ql/src/test/queries/clientpositive/llap_text.q PRE-CREATION > ql/src/test/results/clientpositive/llap_text.q.out PRE-CREATION > storage-api/src/java/org/apache/hadoop/hive/common/io/DiskRangeList.java 62f9d8e > storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java 13772c9 > > Diff: https://reviews.apache.org/r/55247/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============2756048581432864665==--