hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anishek <...@git.apache.org>
Subject [GitHub] hive pull request #129: HIVE-15473: Progress Bar on Beeline client
Date Fri, 06 Jan 2017 09:03:30 GMT
GitHub user anishek opened a pull request:

    https://github.com/apache/hive/pull/129

    HIVE-15473: Progress Bar on Beeline client

    Have a common strategy to rendering the in place updates from both the hive cli and beeline.
Various summary updates once the tez job is completed are no longer rendered with fancy colors.
There is a possible condition where the logRunnable thread requests progress update from the
server before the session state is updated with relevant object (TezJobMonitor in this case)
to provide information. In this case no progress bar will be displayed.
    
    Additionally since on local testing I was doing simple query, due to the wait interval
time of 1 Second between calls the query finishes faster and the progress bar is just stuck
in between and we get the results. hopefully for larger queries it would not be so off, else
we have to do frequent calls to server to get the updates which will just overload it.
    
    
    Squashed commit of the following:
    
    commit 189ed18663f0e3d69cd6ef2770c66f347f44c98f
    Author: Anishek Agarwal <anishek@gmail.com>
    Date:   Fri Jan 6 11:49:14 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        using the correct method call.
    
    commit 22b843ab68c7d2e24ae7ead48e1e6b49850a39ab
    Author: Anishek Agarwal <anishek@gmail.com>
    Date:   Fri Jan 6 10:42:31 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        Reverting the formatting changes
    
    commit 491ecdffd84945a4fbde50e70ae9d4538503bb16
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:45:59 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        Second attempt to use the correct set of imports
    
    commit 6539df6f0bf6dc11e6c686455b1377527096ce84
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:36:01 2017 +0530
    
        Revert "HIVE-15473  Progress Bar on Beeline client" -- reverting this as intellij
git commit optimized imports again in correctly
    
        This reverts commit 0a1b8eff71fccf8ed3bae7c5a8e9dd5eccb753b4.
    
    commit 0a1b8eff71fccf8ed3bae7c5a8e9dd5eccb753b4
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:33:18 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        reverting back to the old style of imports without '*'
    
    commit a2ff2f9e52174f86227ebb539bfba0a08c830cb2
    Author: anishek <anishek@gmail.com>
    Date:   Wed Jan 4 15:45:55 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        removing unnecessary dependency and making sure we show progress only if available
    
    commit 7038c0ccc81273cd1b0872735908772d56d764eb
    Author: anishek <anishek@gmail.com>
    Date:   Wed Jan 4 15:33:05 2017 +0530
    
        HIVE-15473 Progress Bar on Beeline client

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anishek/hive HIVE-15473

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hive/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit 8e49707a8a49a4de096e623846a5d1ccefbd8d9a
Author: Anishek Agarwal <anishek@gmail.com>
Date:   2017-01-06T09:01:21Z

    HIVE-15473: Progress Bar on Beeline client
    
    Squashed commit of the following:
    
    commit 189ed18663f0e3d69cd6ef2770c66f347f44c98f
    Author: Anishek Agarwal <anishek@gmail.com>
    Date:   Fri Jan 6 11:49:14 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        using the correct method call.
    
    commit 22b843ab68c7d2e24ae7ead48e1e6b49850a39ab
    Author: Anishek Agarwal <anishek@gmail.com>
    Date:   Fri Jan 6 10:42:31 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        Reverting the formatting changes
    
    commit 491ecdffd84945a4fbde50e70ae9d4538503bb16
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:45:59 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        Second attempt to use the correct set of imports
    
    commit 6539df6f0bf6dc11e6c686455b1377527096ce84
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:36:01 2017 +0530
    
        Revert "HIVE-15473  Progress Bar on Beeline client" -- reverting this as intellij
git commit optimized imports again in correctly
    
        This reverts commit 0a1b8eff71fccf8ed3bae7c5a8e9dd5eccb753b4.
    
    commit 0a1b8eff71fccf8ed3bae7c5a8e9dd5eccb753b4
    Author: anishek <anishek@gmail.com>
    Date:   Thu Jan 5 14:33:18 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        reverting back to the old style of imports without '*'
    
    commit a2ff2f9e52174f86227ebb539bfba0a08c830cb2
    Author: anishek <anishek@gmail.com>
    Date:   Wed Jan 4 15:45:55 2017 +0530
    
        HIVE-15473  Progress Bar on Beeline client
    
        removing unnecessary dependency and making sure we show progress only if available
    
    commit 7038c0ccc81273cd1b0872735908772d56d764eb
    Author: anishek <anishek@gmail.com>
    Date:   Wed Jan 4 15:33:05 2017 +0530
    
        HIVE-15473 Progress Bar on Beeline client

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message