hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vineet Garg <vg...@hortonworks.com>
Subject Re: Review Request 55952: HIVE-15721 Allow IN/NOT IN correlated subquery with aggregates
Date Wed, 25 Jan 2017 21:12:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55952/
-----------------------------------------------------------

(Updated Jan. 25, 2017, 9:12 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Pre-commit test failure fix


Bugs: HIVE-15721
    https://issues.apache.org/jira/browse/HIVE-15721


Repository: hive-git


Description
-------

This patch lifts restriction on correlated IN/NOT IN subqueries with aggregate. See jira for
more detailed description


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java
564ef7a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 7ca722a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java bd771f9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSQCountCheck.java 53e6231 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBSubQuery.java f9db2c8 
  ql/src/test/queries/clientnegative/subquery_in_implicit_gby.q 338747e 
  ql/src/test/queries/clientnegative/subquery_notin_implicit_gby.q PRE-CREATION 
  ql/src/test/queries/clientpositive/subquery_in.q 7293c77 
  ql/src/test/queries/clientpositive/subquery_notin.q 0883c89 
  ql/src/test/results/clientnegative/subquery_exists_implicit_gby.q.out bab6138 
  ql/src/test/results/clientnegative/subquery_in_implicit_gby.q.out a882fbc 
  ql/src/test/results/clientnegative/subquery_notexists_implicit_gby.q.out bab6138 
  ql/src/test/results/clientnegative/subquery_notin_implicit_gby.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out eae6f1d 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out e8ba117 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 37a6617 

Diff: https://reviews.apache.org/r/55952/diff/


Testing
-------

* Added positive and negative tests.
* Pre-commit testing


Thanks,

Vineet Garg


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message