hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 55846: HIVE-15604: Improve contents of qfile test output
Date Tue, 24 Jan 2017 10:36:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55846/#review162795
-----------------------------------------------------------



Thanks for the patch Zsombor!

It is long overdue to have a usable output from the QTest results.

Just a few questions.
You are not consequent about catching Throwables and Exceptions. Could you please check that?
What was the original intention changing it?

Thanks again!
Peter


itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java
(line 150)
<https://reviews.apache.org/r/55846/#comment234170>

    Why do we change from Throwable to Exception?



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java (line
103)
<https://reviews.apache.org/r/55846/#comment234171>

    Why do not change from Throwable to Exception? :)



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java (line 188)
<https://reviews.apache.org/r/55846/#comment234172>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java (line
155)
<https://reviews.apache.org/r/55846/#comment234173>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java (line
129)
<https://reviews.apache.org/r/55846/#comment234174>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java
(line 111)
<https://reviews.apache.org/r/55846/#comment234175>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java (line
135)
<https://reviews.apache.org/r/55846/#comment234176>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java (line
132)
<https://reviews.apache.org/r/55846/#comment234177>

    As above



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java (lines 1818 - 1820)
<https://reviews.apache.org/r/55846/#comment234169>

    Why do we change the error aggregation here?


- Peter Vary


On Jan. 23, 2017, 4:13 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55846/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 4:13 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15604: Improve contents of qfile test output
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java 06888467ec70eb1780e11969dafe2bff2c432d9d

>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java
9c97c318ee89f598515d7b2e14f7f8184dc1119d 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java
3e4b3732cf49c1ac14baa58b65731f407f2b1dcd 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java a735346c062684eb6069565e7354b875cde44bd7

>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java
71a02bca0b416c264beb00e95d2c3ab8da30b5c1 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java
956a42d2711296061aa09f79596885af475ce6e6 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java
6225180a0735e41f5eee2c32e5b05c674e2edbdd 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java
65b2ce71d3797823c6c14002384857cb2a61749a 
>   itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java
8620cde37894aa5f15a4f7850c6f62c9ac8bf6d1 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestProcessExecResult.java PRE-CREATION

>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 1eaf7af5381a164f442a1094fb2543a08dc6c253

>   itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java 8dba0bb9d5288240414a59f9468d3adae4dd8ef1

> 
> Diff: https://reviews.apache.org/r/55846/diff/
> 
> 
> Testing
> -------
> 
> Ran qtests manually and checked the error messages.
> Checked that for diff failures we now have the output captured from the diff process
in the error message of the failed test.
> Checkout how multiple tests, all with failures, look on the console to make sure that
the results are still readeable/easy to follow.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message