hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chaoyu Tang <ctang...@gmail.com>
Subject Re: Review Request 55731: HIVE-15653: Some ALTER TABLE commands drop table stats
Date Tue, 24 Jan 2017 04:59:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55731/
-----------------------------------------------------------

(Updated Jan. 24, 2017, 4:59 a.m.)


Review request for hive and pengcheng xiong.


Changes
-------

revised patch based on the review.


Bugs: HIVE-15653
    https://issues.apache.org/jira/browse/HIVE-15653


Repository: hive-git


Description
-------

For most of alter table operations like table rename, add columns, change column type etc
(besides the set table properties), the table stats status should not change. But for some
other operations like update statistics, change location, the basic stats status should change.


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 4aea152 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a1fb874 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0f472e7 
  ql/src/test/queries/clientpositive/alter_table_stats_status.q PRE-CREATION 
  ql/src/test/results/clientpositive/alter_table_stats_status.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/55731/diff/


Testing
-------

1. Manual tests
2. new unit tests


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message