hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 55746: HIVE-15664 LLAP text cache: improve first query perf I
Date Tue, 24 Jan 2017 01:38:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55746/#review162733
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1338)
<https://reviews.apache.org/r/55746/#comment234055>

    Can you use hive.exec.orc.dictionary.key.size.threshold=0.0 to disable dictionary instead
of adding new conf?



llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VertorDeserializeOrcWriter.java
(line 83)
<https://reviews.apache.org/r/55746/#comment234063>

    nit: typo



llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VertorDeserializeOrcWriter.java
(line 104)
<https://reviews.apache.org/r/55746/#comment234064>

    nit: typo



orc/src/java/org/apache/orc/OrcConf.java (line 100)
<https://reviews.apache.org/r/55746/#comment234066>

    This can be avoided with the existing conf orc.dictionary.key.threshold


- Prasanth_J


On Jan. 20, 2017, 5:03 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55746/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 5:03 a.m.)
> 
> 
> Review request for hive and Gopal V.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f1f91a 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionDispatcher.java 2d3197c

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java
caa60e5 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 7cfd133

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
1a76eae 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java
2e4f2ba 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java
5cddae5 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java
565e3d2 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
dd189f1 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VertorDeserializeOrcWriter.java
PRE-CREATION 
>   orc/src/java/org/apache/orc/OrcConf.java 357318d 
>   orc/src/java/org/apache/orc/impl/WriterImpl.java 988d9d8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3ee8fdc 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java e3158f6 
>   storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
9c066e0 
> 
> Diff: https://reviews.apache.org/r/55746/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message