hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 55276: HIVE-15539
Date Tue, 10 Jan 2017 10:30:44 GMT


> On Jan. 10, 2017, 12:15 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/multi_insert_with_join2.q, lines 62-69
> > <https://reviews.apache.org/r/55276/diff/1/?file=1598783#file1598783line62>
> >
> >     Can you add following test?
> >     explain
> >     FROM T_A a JOIN T_B b ON a.id = b.id
> >     INSERT OVERWRITE TABLE join_result_1
> >     SELECT a.val, a.id, b.id, b.val
> >     WHERE b.id = 'Id_1' AND b.val = 'val_103'
> >     INSERT OVERWRITE TABLE join_result_3
> >     SELECT a.id, b.val, b.id, a.val
> >     WHERE b.val = 'val_104' AND b.id = 'Id_2';

Added and verified plan.


> On Jan. 10, 2017, 12:15 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 517
> > <https://reviews.apache.org/r/55276/diff/1/?file=1598779#file1598779line517>
> >
> >     Is multimap really needed here. Seems like nodes declared above would have sufficied
here?

Actually this is related to the object above. Comment was not in the right place. I could
remove indeed _nodes_ list. However, this should be a _multimap_. The reason is that we need
to keep all nodes from all insert statements so we can modify them after creating the subquery
(loop in L589).


> On Jan. 10, 2017, 12:15 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java, line 608
> > <https://reviews.apache.org/r/55276/diff/1/?file=1598779#file1598779line608>
> >
> >     Will be good to add comment on what this loop is doing?

Updated comment in L599 to reflect we rewrite all references.


- Jesús


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55276/#review160938
-----------------------------------------------------------


On Jan. 6, 2017, 7:21 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55276/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 7:21 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Vineet Garg.
> 
> 
> Bugs: HIVE-15539
>     https://issues.apache.org/jira/browse/HIVE-15539
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15539
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
0038f730e6a5500fda92e795e814d5efce567e2e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fdb468d6047b68a97cbb6248e38ef0982248ba2e

>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java f549dff3148deed158a149956d5c1ff61db8b00f

>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d0131b70239dd32cc82c801f35180d2a6a1cef88

>   ql/src/test/queries/clientpositive/multi_insert_gby4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/multi_insert_with_join2.q 1529fa2fa3faaf303ac8d2ddac421e86ef0f9ce9

>   ql/src/test/results/clientpositive/auto_sortmerge_join_13.q.out b45411cbf638a1bc3e7d720990f6786be9ef445d

>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 6572f6ca577c8647b6023f108bd3cf289d9b0a88

>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out ce713547c80e519239ce82e680ad07a0ccae7d45

>   ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out e9990775bd40791b4b5b71716703af48da4a4a4e

>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_13.q.out a539e03b0892acb4ad6c028d89bf49cb9252152d

>   ql/src/test/results/clientpositive/llap/explainuser_2.q.out 931f1a2db0dd4f0ecc5f12f859c2853e83fbfbab

>   ql/src/test/results/clientpositive/llap/lineage3.q.out 72a93445d191e4c465ead011fe6b2e35235d03a4

>   ql/src/test/results/clientpositive/llap/tez_union_multiinsert.q.out 9b7612d8650d44691c68b6b39eb4646d9dfe0a07

>   ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out 624d8860aa9cafe667d79cdfea90a45b08cae4cc

>   ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out 735e4f435f6e2e50c9439b2a7aa437c33130b43f

>   ql/src/test/results/clientpositive/multi_insert_gby4.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/multi_insert_union_src.q.out 2036e6354efbe4a291ef93a37cf877e638e36b4f

>   ql/src/test/results/clientpositive/multi_insert_with_join2.q.out 70a044de93a61819e1641422914d61b7a52fbd19

>   ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 0e99972fceab1453d0d349f45d92519d67e27e91

>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_13.q.out fb077718d0f25e6dbb4bd83380f647a994c2e222

>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 92ca67bc174a881fd556ec13f997d792c11285ec

>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out f7f4dbb2fcc73182c0f65e774e8195dad3907273

>   ql/src/test/results/clientpositive/spark/union17.q.out ce23773671859ede11a513a8b43221d746fa73ba

>   ql/src/test/results/clientpositive/spark/union18.q.out f9a28bb77f78532516e3ef464afa2da0602ed036

>   ql/src/test/results/clientpositive/spark/union19.q.out d81c19b286c517523e9bda7cc97b71058be9091a

>   ql/src/test/results/clientpositive/spark/union31.q.out a1f29eb485b5ddcda068c2e97a4515fbedea5a20

>   ql/src/test/results/clientpositive/spark/union_remove_6.q.out 1bdeb09b5f0030972d937fec2404b9b14361bce3

>   ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out cebea03830c044243a4429ffbeccde474c204792

>   ql/src/test/results/clientpositive/tez/explainanalyze_2.q.out c99acc923b19be67e5f2e5eb3fb83b3e6da8b67a

>   ql/src/test/results/clientpositive/union17.q.out 650aef434cd1941ce87df5f366e09d088ca72c0d

>   ql/src/test/results/clientpositive/union18.q.out 599328071f2853de5c34ecd9b6408de691e33d78

>   ql/src/test/results/clientpositive/union19.q.out 89d9c6d546fb35494a3b00792dd81f9c50d2b49e

>   ql/src/test/results/clientpositive/union31.q.out bb35d5c78808f2b7bdcafb85844d7304cfc12726

>   ql/src/test/results/clientpositive/union_remove_6.q.out 0a80e63ae50b1ad3c16bf11d05c18c6ec726d38f

>   ql/src/test/results/clientpositive/union_remove_6_subq.q.out 7b306edb1c79e61f1d16262f7338f2869193aa0b

> 
> Diff: https://reviews.apache.org/r/55276/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message