hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dere <jd...@hortonworks.com>
Subject Re: Review Request 55194: HIVE-15541: Hive OOM when ATSHook enabled and ATS goes down
Date Thu, 05 Jan 2017 18:34:09 GMT


> On Jan. 5, 2017, 9:38 a.m., Barna Zsombor Klara wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java, line 208
> > <https://reviews.apache.org/r/55194/diff/1/?file=1597091#file1597091line208>
> >
> >     Should this be logged at INFO lvl? I understand that the hive query can still
be executed just because we couldn't send the data to Yarn, but shouldn't it be at least a
warning since something went wrong?

Makes sense, will change to warning level logs


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55194/#review160571
-----------------------------------------------------------


On Jan. 5, 2017, 2:28 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55194/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 2:28 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-15541
>     https://issues.apache.org/jira/browse/HIVE-15541
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Create the ATSHook executor with a bounded queue capacity
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47db0c0 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java 3651c9c 
> 
> Diff: https://reviews.apache.org/r/55194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message