Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24514200BE3 for ; Thu, 8 Dec 2016 00:28:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 22D71160B26; Wed, 7 Dec 2016 23:28:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C098160B0C for ; Thu, 8 Dec 2016 00:28:14 +0100 (CET) Received: (qmail 45050 invoked by uid 500); 7 Dec 2016 23:28:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 45029 invoked by uid 99); 7 Dec 2016 23:28:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 23:28:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D82662DA92A; Wed, 7 Dec 2016 23:28:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7611418273227175666==" MIME-Version: 1.0 Subject: Review Request 54505: HIVE-15331: Decimal multiplication with high precision/scale often returns NULL From: Jason Dere To: hive , Jason Dere Date: Wed, 07 Dec 2016 23:28:07 -0000 Message-ID: <20161207232807.1680.9047@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jason Dere X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54505/ X-Sender: Jason Dere Reply-To: Jason Dere X-ReviewRequest-Repository: hive-git archived-at: Wed, 07 Dec 2016 23:28:15 -0000 --===============7611418273227175666== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54505/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-15331 https://issues.apache.org/jira/browse/HIVE-15331 Repository: hive-git Description ------- Change adjusted decimal precision/scale of arithmetic operators when desired precision/scale exceeds max precision Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java ef6ef11 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 89e69be ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 9d283bd ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java 7dc1f83 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericMinus.java a31cf78 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericPlus.java b055776 ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 6fa3b3f ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java e342a76 ql/src/test/results/clientpositive/decimal_precision.q.out 9fbc8f5 ql/src/test/results/clientpositive/decimal_udf.q.out c0baab8 ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out bce4b12 ql/src/test/results/clientpositive/llap/vector_decimal_precision.q.out 3c932e2 ql/src/test/results/clientpositive/llap/vector_decimal_udf.q.out 0813854 ql/src/test/results/clientpositive/vector_decimal_expressions.q.out db160e1 ql/src/test/results/clientpositive/vector_decimal_precision.q.out ca14c44 Diff: https://reviews.apache.org/r/54505/diff/ Testing ------- Thanks, Jason Dere --===============7611418273227175666==--