Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C1380200BD3 for ; Tue, 6 Dec 2016 23:59:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BFD69160B1B; Tue, 6 Dec 2016 22:59:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 147A1160B17 for ; Tue, 6 Dec 2016 23:59:35 +0100 (CET) Received: (qmail 12122 invoked by uid 500); 6 Dec 2016 22:59:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 12100 invoked by uid 99); 6 Dec 2016 22:59:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 22:59:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D81E2D9010; Tue, 6 Dec 2016 22:59:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0046039730702131563==" MIME-Version: 1.0 Subject: Re: Review Request 54236: HIVE-15296 AM may lose task failures and not reschedule when scheduling to LLAP From: Gopal V To: j.prasanth.j@gmail.com, Siddharth Seth Cc: Sergey Shelukhin , hive , Gopal V Date: Tue, 06 Dec 2016 22:59:34 -0000 Message-ID: <20161206225934.1680.12518@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gopal V X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54236/ X-Sender: Gopal V References: <20161130233953.1642.69183@reviews.apache.org> In-Reply-To: <20161130233953.1642.69183@reviews.apache.org> Reply-To: Gopal V X-ReviewRequest-Repository: hive-git archived-at: Tue, 06 Dec 2016 22:59:36 -0000 --===============0046039730702131563== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54236/#review158235 ----------------------------------------------------------- llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java (line 191) This is async update to an object in the pending events queue. Possible sync issues? - Gopal V On Nov. 30, 2016, 11:39 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54236/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 11:39 p.m.) > > > Review request for hive, Prasanth_J and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java 4933fb3 > llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java 0581681 > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java ea47330 > llap-common/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java 9549567 > llap-common/src/protobuf/LlapDaemonProtocol.proto 2e74c18 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 04c28cb > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 91a321d > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 752e6ee > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 0deebf9 > > Diff: https://reviews.apache.org/r/54236/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============0046039730702131563==--