hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Dai <dai...@gmail.com>
Subject Re: Review Request 54826: HIVE-15448: ChangeManager for replication
Date Tue, 27 Dec 2016 16:44:32 GMT


> On Dec. 27, 2016, 6:26 a.m., Thejas Nair wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java, line
55
> > <https://reviews.apache.org/r/54826/diff/1-2/?file=1588285#file1588285line55>
> >
> >     seems better as local to the reycle method, as its not used outside.
> 
> Daniel Dai wrote:
>     I mean to cache user/group as it should not be changed. I don't want to calculate
them everytime, and taking risk current user being changed unexpected.

Put in the construct


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54826/#review160135
-----------------------------------------------------------


On Dec. 27, 2016, 6:55 a.m., Daniel Dai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54826/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 6:55 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See HIVE-15448
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b4e89b0 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestReplChangeManager.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 2892da3 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java PRE-CREATION

>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 6aca1b7 
> 
> Diff: https://reviews.apache.org/r/54826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Dai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message