hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <the...@hortonworks.com>
Subject Re: Review Request 54771: Capture additional metadata to replicate a simple insert at destination
Date Mon, 19 Dec 2016 20:56:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54771/#review159649
-----------------------------------------------------------




itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
(line 1206)
<https://reviews.apache.org/r/54771/#comment230671>

    can you add a verifyInsertJSON method or so ? looks like we can avoid the many repeating
lines that way.


- Thejas Nair


On Dec. 19, 2016, 5:30 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54771/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 5:30 p.m.)
> 
> 
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
> 
> 
> Bugs: HIVE-15294
>     https://issues.apache.org/jira/browse/HIVE-15294
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-15294
> 
> 
> Diffs
> -----
> 
>   hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
119801f 
>   itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
0b691b1 
>   metastore/if/hive_metastore.thrift 6f77156 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d0a66b0 
>   metastore/src/java/org/apache/hadoop/hive/metastore/events/InsertEvent.java 102754e

>   metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java adf2fd8

>   metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java
ef89b17 
>   metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java
0407210 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f62d5f3 
>   shims/common/src/main/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java bd97521 
> 
> Diff: https://reviews.apache.org/r/54771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message