hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dere <jd...@hortonworks.com>
Subject Review Request 54505: HIVE-15331: Decimal multiplication with high precision/scale often returns NULL
Date Wed, 07 Dec 2016 23:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54505/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-15331
    https://issues.apache.org/jira/browse/HIVE-15331


Repository: hive-git


Description
-------

Change adjusted decimal precision/scale of arithmetic operators when desired precision/scale
exceeds max precision


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java ef6ef11 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 89e69be 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 9d283bd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java 7dc1f83 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericMinus.java a31cf78

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNumericPlus.java b055776 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 6fa3b3f 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java e342a76

  ql/src/test/results/clientpositive/decimal_precision.q.out 9fbc8f5 
  ql/src/test/results/clientpositive/decimal_udf.q.out c0baab8 
  ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out bce4b12 
  ql/src/test/results/clientpositive/llap/vector_decimal_precision.q.out 3c932e2 
  ql/src/test/results/clientpositive/llap/vector_decimal_udf.q.out 0813854 
  ql/src/test/results/clientpositive/vector_decimal_expressions.q.out db160e1 
  ql/src/test/results/clientpositive/vector_decimal_precision.q.out ca14c44 

Diff: https://reviews.apache.org/r/54505/diff/


Testing
-------


Thanks,

Jason Dere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message