hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Hsu <a...@linkedin.com>
Subject Review Request 54341: HIVE-15353: Metastore throws NPE if StorageDescriptor.cols is null
Date Sat, 03 Dec 2016 19:02:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54341/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-15353
    https://issues.apache.org/jira/browse/HIVE-15353


Repository: hive-git


Description
-------

Set a default value for StorageDescriptor.cols of empty list to avoid having to do null checks
everywhere. However, null checks are still needed to guard against existing null values in
the database (add_partition previously allowed you to store nulls in the database).


Diffs
-----

  metastore/if/hive_metastore.thrift baab31bb0f44361847224843f905c0417b1670be 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 6838133083684ee3b93a93129bb492ab29a4842e

  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java
938f06bbce7a2b213e901f153e1da4606339c0cf 
  metastore/src/gen/thrift/gen-php/metastore/Types.php b9af4efc5f8b7cdf19236db7d68865bdec8382a5

  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 21c039006fc05bc603fda0eeedc92174583f8403

  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb c73593298bbddb46e0926b01ccb9c6fb5d880452

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 86565a4198d5daced5e230a41d8ada577a656268

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 9ea6ac40d6f0eb9081c5cfad982ffc435f15f6fd


Diff: https://reviews.apache.org/r/54341/diff/


Testing
-------

After making these changes, I no longer encounter NullPointerExceptions when setting cols
to null in create_table, alter_table, and alter_partition calls.


Thanks,

Anthony Hsu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message