Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============7692791630996954676=="
MIME-Version: 1.0
Subject: Re: Review Request 54065: HIVE-15282: Different modification times
 are used when an index is built and when its staleness is checked
From: Peter Vary <pvary@cloudera.com>
To: Peter Vary <pvary@cloudera.com>, Sergio Pena <sergio.pena@cloudera.com>,
 Aihua Xu <axu@cloudera.com>
Cc: hive <dev@hive.apache.org>, Marta Kuczora <kuczoram@cloudera.com>
Date: Mon, 28 Nov 2016 11:10:08 -0000
Message-ID: <20161128111008.5576.37218@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Peter Vary <noreply@reviews.apache.org>
References: <20161124151722.27388.97900@reviews.apache.org>
In-Reply-To: <20161124151722.27388.97900@reviews.apache.org>
Reply-To: Peter Vary <pvary@cloudera.com>
archived-at: Mon, 28 Nov 2016 11:10:12 -0000

--===============7692791630996954676==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54065/#review157014
-----------------------------------------------------------


Thanks for the patch!

Nice detailed description on the Jira.

Thansk for tracking this issue dowm!


ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 978)
<https://reviews.apache.org/r/54065/#comment227393>

    We might want to use the dataLocation local variable here


- Peter Vary


On Nov. 24, 2016, 3:17 p.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54065/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 3:17 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-15282
>     https://issues.apache.org/jira/browse/HIVE-15282
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed the way how the modification time is determined for partitions in the DDLTask.alterIndex method to be the same as when the index staleness is checked. Instead of using the modification date of the partition folder, go through the files in the folder and use the highest modification time and save it as index property. With this we can avoid the issue when the folder and the file is created when the second turns. So the modification time of the folder is in the previous second compared to the modification time of the file.
> If the partition folder doesn't contain any files, then use the folder's modification time, just as before.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cfece77 
> 
> Diff: https://reviews.apache.org/r/54065/diff/
> 
> 
> Testing
> -------
> 
> Ran the index_auto_mult_tables_compact and index_auto_mult_tables q tests multiple times, with hard-coded delay with which the test failure described in HIVE-15282 could be reproduced. With the patch, the tests were always successful.
> Also ran all index related q tests.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>


--===============7692791630996954676==--