Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5BEBE200BC2 for ; Thu, 17 Nov 2016 22:26:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5A291160B0B; Thu, 17 Nov 2016 21:26:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A2EBA160AD8 for ; Thu, 17 Nov 2016 22:26:53 +0100 (CET) Received: (qmail 73114 invoked by uid 500); 17 Nov 2016 21:26:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 73100 invoked by uid 99); 17 Nov 2016 21:26:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 21:26:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 373BD1CF890; Thu, 17 Nov 2016 21:26:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6688221000747879939==" MIME-Version: 1.0 Subject: Re: Review Request 53838: HIVE-15232: Add notification events for functions and indexes From: Mohit Sabharwal To: hive , Mohit Sabharwal , Chaoyu Tang Date: Thu, 17 Nov 2016 21:26:51 -0000 Message-ID: <20161117212651.20484.17826@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mohit Sabharwal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53838/ X-Sender: Mohit Sabharwal References: <20161117204859.20485.74239@reviews.apache.org> In-Reply-To: <20161117204859.20485.74239@reviews.apache.org> X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java X-ReviewBoard-Diff-For: metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java X-ReviewBoard-Diff-For: metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java X-ReviewBoard-Diff-For: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java Reply-To: Mohit Sabharwal X-ReviewRequest-Repository: hive-git archived-at: Thu, 17 Nov 2016 21:26:54 -0000 --===============6688221000747879939== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53838/ ----------------------------------------------------------- (Updated Nov. 17, 2016, 9:26 p.m.) Review request for hive. Changes ------- Incorp. review feedback. Bugs: HIVE-15232 https://issues.apache.org/jira/browse/HIVE-15232 Repository: hive-git Description ------- Adds notification events for Create/Drop Function and Create/Drop/Alter Index. Diffs (updated) ----- hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java 72930eb66c2b44fc6ee414c40ead713eb83413c1 hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 0b3d89198f1d89c057d2639b89799b53b4a09163 hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/AlterIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateFunctionMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/CreateIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropFunctionMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/DropIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/HCatEventMessage.java 538fa68a83081604ca6598d886021a633dfecea7 hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageDeserializer.java 8ea39987f022175f0bcb6e1ecd0945847fd70996 hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/MessageFactory.java 0710dd09dbafb11ce3a4819bc2bd5f50bf70dc84 hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONAlterIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONCreateIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropFunctionMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONDropIndexMessage.java PRE-CREATION hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageDeserializer.java 834fdde113a293fcc595c8bfe329a9299ae8aabc hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json/JSONMessageFactory.java 6b74b54b5d8f3ef8735b8bae5535567a7c4dc76a itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 4a7801bbf010dbcfa2044381cfd2e913f83f5445 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cd32d5859899960337c9525ac033cd1cfb64ab2 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0ef25e103d0b7cbb187cea2111efc6a40e01d85 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 5e46ae1d83296d11957038c76ee2e4d207db8992 metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateFunctionEvent.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/events/DropFunctionEvent.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java a3b16d049c9c06f08e5ef8809ad386274479d66d Diff: https://reviews.apache.org/r/53838/diff/ Testing ------- Verified using TestDbNotificationListener Thanks, Mohit Sabharwal --===============6688221000747879939==--