hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken
Date Mon, 14 Nov 2016 20:37:07 GMT


> On Nov. 11, 2016, 12:28 a.m., Prasanth_J wrote:
> > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java,
line 329
> > <https://reviews.apache.org/r/53593/diff/1/?file=1558789#file1558789line329>
> >
> >     nit: Can the batchkey be null?

no


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53593/#review155661
-----------------------------------------------------------


On Nov. 9, 2016, 2:34 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53593/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 2:34 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java a27266f

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java
2fa68a9 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
eb8ee6c 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java c9b0a4d

>   orc/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java c347181 
>   orc/src/java/org/apache/orc/impl/TreeReaderFactory.java 245e3ce 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java a9dbc3e 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ccb39da 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReader.java 4d09dcd 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java bcb54d6

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java
ebbdf8d 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 4405232 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 5cc3663 
>   ql/src/test/queries/clientpositive/vector_complex_all.q 91a7368 
>   ql/src/test/results/clientpositive/llap/vector_complex_all.q.out 08d49bc 
>   ql/src/test/results/clientpositive/vector_complex_all.q.out a54a371 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 76a1286 
>   storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
907181e 
> 
> Diff: https://reviews.apache.org/r/53593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message