hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mohit Sabharwal <mo...@cloudera.com>
Subject Re: Review Request 52800: HIVE-13966: DbNotificationListener: can loose DDL operation notifications
Date Thu, 10 Nov 2016 17:33:55 GMT


> On Nov. 8, 2016, 4:13 p.m., Chaoyu Tang wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java, line 86
> > <https://reviews.apache.org/r/52800/diff/1/?file=1556283#file1556283line86>
> >
> >     I wonder if the API changes will cause some backward compatibility issue, if
the HiveMetaStore is currently the only consumer of the AlterHandler, it should be fine.
> 
> Mohit Sabharwal wrote:
>     That's a good point. I have created new versions of these methods. But adding new
methods makes it backward compatibility as well, right ? I'm not sure there is a good solution
here.
> 
> Chaoyu Tang wrote:
>     Yeah, that was what I thought, add new APIs and mark the old ones as deprecated.
Besides this, I do not have other better solution as well.

Ok, thanks, marking old ones as deprecated.


- Mohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52800/#review155256
-----------------------------------------------------------


On Nov. 10, 2016, 3:43 a.m., Mohit Sabharwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52800/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 3:43 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13966
>     https://issues.apache.org/jira/browse/HIVE-13966
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Metadata event and associated notification should be committed in the same
> JDO transaction.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7ce29e10798730061d02fadb55423bea3b69c6ac

>   itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
PRE-CREATION 
>   itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java
81ce67bdc8fdaf11ff4fec3f255ed0021a4752c7 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
af16f75e63c372c37bfd73567b777bba53f94db3 
>   metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java dedd4497adfcc9d57090a943f6bb4f35ea87fa61

>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 40b337a9e40ea04a37f108146853d2d1f42dcd29

>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 60e462fd06a3f84d5b87cd335afb49768cb27562

> 
> Diff: https://reviews.apache.org/r/52800/diff/
> 
> 
> Testing
> -------
> 
> Enhanced TestDbNotificationListener
> 
> 
> Thanks,
> 
> Mohit Sabharwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message