hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Barna Zsombor Klara <zsombor.kl...@cloudera.com>
Subject Re: Review Request 53609: HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
Date Thu, 10 Nov 2016 10:31:24 GMT


> On Nov. 9, 2016, 4:48 p.m., Peter Vary wrote:
> > spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java, line 39
> > <https://reviews.apache.org/r/53609/diff/1/?file=1559404#file1559404line39>
> >
> >     nit: Is this import is used after this change?

Yes, Future is still being used.


- Barna Zsombor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53609/#review155444
-----------------------------------------------------------


On Nov. 9, 2016, 3:20 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53609/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 3:20 p.m.)
> 
> 
> Review request for hive, Rui Li and Xuefu Zhang.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)
> 
> 
> Diffs
> -----
> 
>   spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 863aaa877769094164c209bd5861515d91ed250c

>   spark-client/src/main/java/org/apache/hive/spark/client/rpc/Rpc.java b2f133b6aa3abdb74e83eab8b14cd827b0de60dc

>   spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java 77c3d020529d60539e3044aaa36a7fb69583ea4b

> 
> Diff: https://reviews.apache.org/r/53609/diff/
> 
> 
> Testing
> -------
> 
> Ran modified unit tests / tests of the modified classes.
> Ran simple queries with spark as the execution engine.
> Tested that the jobSubmission test is passing if the thread is blocked for 3 seconds
in the ClientProtocol#submit.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message