Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36EDB200BA3 for ; Thu, 20 Oct 2016 20:12:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 35A80160AE0; Thu, 20 Oct 2016 18:12:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D9D1160ACC for ; Thu, 20 Oct 2016 20:12:36 +0200 (CEST) Received: (qmail 54047 invoked by uid 500); 20 Oct 2016 18:12:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 54026 invoked by uid 99); 20 Oct 2016 18:12:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 18:12:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ECEDE25BBD0; Thu, 20 Oct 2016 18:12:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4445887493620492122==" MIME-Version: 1.0 Subject: Re: Review Request 51755: Support Intersect Except From: pengcheng xiong To: Ashutosh Chauhan Cc: pengcheng xiong , hive Date: Thu, 20 Oct 2016 18:12:34 -0000 Message-ID: <20161020181234.1642.22524@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengcheng xiong X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51755/ X-Sender: pengcheng xiong References: <20161019013606.14471.23848@reviews.apache.org> In-Reply-To: <20161019013606.14471.23848@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/except_distinct.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/intersect_distinct.q.out X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/intersect_distinct.q X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectOverIntersectRemoveRule.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/except_all.q.out X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/intersect_all.q.out X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectRewriteRule.java X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveIntersect.java X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/except_distinct.q X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExcept.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/intersect_merge.q.out X-ReviewBoard-Diff-For: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExceptRewriteRule.java X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/except_all.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/intersect_all.q X-ReviewBoard-Diff-For: ql/src/test/queries/clientpositive/intersect_merge.q Reply-To: pengcheng xiong X-ReviewRequest-Repository: hive-git archived-at: Thu, 20 Oct 2016 18:12:37 -0000 --===============4445887493620492122== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ ----------------------------------------------------------- (Updated Oct. 20, 2016, 6:12 p.m.) Review request for hive and Ashutosh Chauhan. Summary (updated) ----------------- Support Intersect Except Repository: hive-git Description ------- HIVE-12765 Diffs (updated) ----- itests/src/test/resources/testconfiguration.properties 09833ff ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f308832 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java c527e58 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java cf93ed8 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExcept.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveIntersect.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExceptRewriteRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectRewriteRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectOverIntersectRemoveRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortLimitPullUpConstantsRule.java 3ec9dac ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 63aa086 ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java d32a0a7 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 5d3fa6a ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5c16c55 ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 50987c3 ql/src/java/org/apache/hadoop/hive/ql/parse/QBExpr.java cccf0f6 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9d58193 ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java a427803 ql/src/test/queries/clientpositive/except_all.q PRE-CREATION ql/src/test/queries/clientpositive/except_distinct.q PRE-CREATION ql/src/test/queries/clientpositive/intersect_all.q PRE-CREATION ql/src/test/queries/clientpositive/intersect_distinct.q PRE-CREATION ql/src/test/queries/clientpositive/intersect_merge.q PRE-CREATION ql/src/test/results/clientpositive/except_all.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/except_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/intersect_all.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/intersect_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/intersect_merge.q.out PRE-CREATION Diff: https://reviews.apache.org/r/51755/diff/ Testing ------- Thanks, pengcheng xiong --===============4445887493620492122==--