Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============6243826357902943793=="
MIME-Version: 1.0
Subject: Re: Review Request 52923: HIVE-14979 Removing stale Zookeeper locks at
 HiveServer2 initialization
From: Lefty Leverenz <leftyleverenz@gmail.com>
To: Barna Zsombor Klara <zsombor.klara@cloudera.com>,
 Ashutosh Chauhan <hashutosh@apache.org>, Marta Kuczora <kuczoram@cloudera.com>,
 Miklos Csanady <miklos.csanady@cloudera.com>, namit jain <njain@fb.com>,
 Sergio Pena <sergio.pena@cloudera.com>
Cc: Peter Vary <pvary@cloudera.com>, hive <dev@hive.apache.org>,
 Lefty Leverenz <leftyleverenz@gmail.com>
Date: Thu, 20 Oct 2016 07:19:36 -0000
Message-ID: <20161020071936.1643.87415@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Lefty Leverenz <noreply@reviews.apache.org>
References: <20161019115046.5284.98955@reviews.apache.org>
In-Reply-To: <20161019115046.5284.98955@reviews.apache.org>
Reply-To: Lefty Leverenz <leftyleverenz@gmail.com>
archived-at: Thu, 20 Oct 2016 07:19:39 -0000

--===============6243826357902943793==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52923/#review153357
-----------------------------------------------------------


common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 1766 - 1772)
<https://reviews.apache.org/r/52923/#comment222656>

    Looks good, thanks.  Just one more nit (on 2 lines):  Zookeeper -> ZooKeeper.
    
    See https://zookeeper.apache.org if you don't believe me.  ;)


- Lefty Leverenz


On Oct. 19, 2016, 11:50 a.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52923/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 11:50 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Marta Kuczora, Miklos Csanady, namit jain, Sergio Pena, and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-14979
>     https://issues.apache.org/jira/browse/HIVE-14979
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adding a new configuration option to HiveConf to signal whether stale lock removal is requested on startup.
> Adding a new method to ZooKeeperHiveLockManager to remove stale locks
> Modifying the HiveServer2 to instantiate a lock manager and call the new method if defined by the configuration.
> 
> Please take extra care when reviewing these:
> - Modifying the lock fetching method to use the clientIp from the lock, and not update with the current ip - Not sure why it was done before
> - Instantiation of the lock manager - I might not chose the best method for it
> 
> Open for any suggestions :)
> 
> Thanks,
> Peter
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8ffae3b 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 14d0ef4 
>   ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java 3f9926e 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 590b1f3 
> 
> Diff: https://reviews.apache.org/r/52923/diff/
> 
> 
> Testing
> -------
> 
> Created 2 unit test cases:
> - Removing own locks
> - Not removing other server's locks
> 
> Manually tested the Lock manager instantiation method on HiveServer2
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


--===============6243826357902943793==--