Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BA3BE200BB1 for ; Thu, 20 Oct 2016 04:36:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B8E27160AFB; Thu, 20 Oct 2016 02:36:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D951160AEA for ; Thu, 20 Oct 2016 04:36:09 +0200 (CEST) Received: (qmail 8148 invoked by uid 500); 20 Oct 2016 02:36:09 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 8128 invoked by uid 99); 20 Oct 2016 02:36:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 02:36:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 672882D9DED; Thu, 20 Oct 2016 02:36:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2127327657102057739==" MIME-Version: 1.0 Subject: Re: Review Request 52981: HIVE-14679: csv2/tsv2 output format disables quoting by default and it's difficult to enable From: cheng xu To: cheng xu Cc: Jianguo Tian , hive Date: Thu, 20 Oct 2016 02:36:06 -0000 Message-ID: <20161020023606.5284.64109@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: cheng xu X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52981/ X-Sender: cheng xu References: <20161019115557.5284.34391@reviews.apache.org> In-Reply-To: <20161019115557.5284.34391@reviews.apache.org> X-ReviewBoard-Diff-For: beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java Reply-To: cheng xu X-ReviewRequest-Repository: hive-git archived-at: Thu, 20 Oct 2016 02:36:10 -0000 --===============2127327657102057739== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52981/#review153339 ----------------------------------------------------------- beeline/src/java/org/apache/hive/beeline/Commands.java (line 650) No space needed after set. beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java (line 105) Why default value is true? beeline/src/main/resources/BeeLine.properties (line 190) If this option is not applicable for all outputformat, can you please make it clear what kind of outputformat the options can be applied? beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 48) Please add a test like ""value"" beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 69) AFAIK, this option doesn't affect csv/tsv/dsv. So you can see no change after enabling it. Please remove them if my understanding is correct. beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 115) I am not sure why default value is true. If the default value is true, no need to set it again here. And we should test the case when quoting is disabled. beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 182) hint: is that possible to reuse the code in TestBufferedRows? beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java (line 217) Remove this line please. - cheng xu On Oct. 19, 2016, 7:55 p.m., Jianguo Tian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52981/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 7:55 p.m.) > > > Review request for hive and cheng xu. > > > Bugs: HIVE-14679 > https://issues.apache.org/jira/browse/HIVE-14679 > > > Repository: hive-git > > > Description > ------- > > 1. Quoting should be enabled by default for csv2, tsv2 and dsv. > 2. Disabling quoting should be possible using a beeline argument. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 79922d2 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 57b9c46 > beeline/src/java/org/apache/hive/beeline/Commands.java 039e354 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 66d9fd0 > beeline/src/main/resources/BeeLine.properties ad79c01 > beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java PRE-CREATION > > Diff: https://reviews.apache.org/r/52981/diff/ > > > Testing > ------- > > Test csv2,tsv2,dsv,csv and tsv output format with enabling double quotes. > > > Thanks, > > Jianguo Tian > > --===============2127327657102057739==--