Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A1563200BA6 for ; Tue, 18 Oct 2016 19:59:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9FF61160AE5; Tue, 18 Oct 2016 17:59:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4447160ACE for ; Tue, 18 Oct 2016 19:59:03 +0200 (CEST) Received: (qmail 99392 invoked by uid 500); 18 Oct 2016 17:59:02 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 99376 invoked by uid 99); 18 Oct 2016 17:59:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2016 17:59:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8960E2D99AC; Tue, 18 Oct 2016 17:59:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4292169471667702720==" MIME-Version: 1.0 Subject: Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests From: Vineet Garg To: Ashutosh Chauhan Cc: hive , Vineet Garg Date: Tue, 18 Oct 2016 17:59:01 -0000 Message-ID: <20161018175901.5284.61352@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vineet Garg X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52708/ X-Sender: Vineet Garg References: <20161014202336.1719.7179@reviews.apache.org> In-Reply-To: <20161014202336.1719.7179@reviews.apache.org> X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out Reply-To: Vineet Garg X-ReviewRequest-Repository: hive-git archived-at: Tue, 18 Oct 2016 17:59:04 -0000 --===============4292169471667702720== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 14, 2016, 8:23 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/insert1.q, lines 49-51 > > > > > > insert overwrite local dir is best tested on cluster. So, doesnt make sense in ut. So should we keep this in system tests ? - Vineet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52708/#review152425 ----------------------------------------------------------- On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52708/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 5:46 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-14913 > https://issues.apache.org/jira/browse/HIVE-14913 > > > Repository: hive-git > > > Description > ------- > > Moved bunch of system tests to hive unit tests > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 97e310d > ql/src/test/queries/clientpositive/cte_1.q ca4132f > ql/src/test/queries/clientpositive/cte_2.q b49620a > ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885 > ql/src/test/queries/clientpositive/insert1.q 4117b54 > ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466 > ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a > ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85 > ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q d971649 > ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a > ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6 > ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71 > ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095 > ql/src/test/results/clientpositive/insert1.q.out 7a2c429 > ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7 > ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded > ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156 > ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351 > ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024 > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3 > ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out ed698e1 > ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c > ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04 > ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd > ql/src/test/results/clientpositive/vectorization_0.q.out ac33721 > > Diff: https://reviews.apache.org/r/52708/diff/ > > > Testing > ------- > > Pre-commit testing > > > Thanks, > > Vineet Garg > > --===============4292169471667702720==--