Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D4BBA200BA6 for ; Tue, 18 Oct 2016 16:54:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D30D0160ADC; Tue, 18 Oct 2016 14:54:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 26210160ACC for ; Tue, 18 Oct 2016 16:54:10 +0200 (CEST) Received: (qmail 96556 invoked by uid 500); 18 Oct 2016 14:54:10 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 96529 invoked by uid 99); 18 Oct 2016 14:54:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2016 14:54:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 89FF82D9875; Tue, 18 Oct 2016 14:54:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3071567169680140131==" MIME-Version: 1.0 Subject: Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable From: Peter Vary To: Zoltan Haindrich , j.prasanth.j@gmail.com, Siddharth Seth , Barna Zsombor Klara , Sergey Shelukhin , Marta Kuczora , Miklos Csanady , Sergio Pena Cc: Peter Vary , hive Date: Tue, 18 Oct 2016 14:54:08 -0000 Message-ID: <20161018145408.5284.17694@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Peter Vary X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52978/ X-Sender: Peter Vary References: <20161018070238.14471.94973@reviews.apache.org> In-Reply-To: <20161018070238.14471.94973@reviews.apache.org> X-ReviewBoard-Diff-For: itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java X-ReviewBoard-Diff-For: itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java X-ReviewBoard-Diff-For: ql/src/test/results/clientpositive/beeline/escape_comments.q.out Reply-To: Peter Vary X-ReviewRequest-Repository: hive-git archived-at: Tue, 18 Oct 2016 14:54:12 -0000 --===============3071567169680140131== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/ ----------------------------------------------------------- (Updated Oct. 18, 2016, 2:54 p.m.) Review request for hive, Zoltan Haindrich, Marta Kuczora, Miklos Csanady, Prasanth_J, Sergey Shelukhin, Sergio Pena, Siddharth Seth, and Barna Zsombor Klara. Changes ------- Updated the diff algorithm, so the diff results are printed not just an unhelpfull yes/no. Hidden an asynchronous log message. Bugs: HIVE-14459 https://issues.apache.org/jira/browse/HIVE-14459 Repository: hive-git Description ------- Kept the changes minimal with the sole goal to be able to run the BeeLine query tests multiple times successfully. - Enabled the driver - Modified the regexps to hide when comparing the results - Configured to run only 1 qtest file - so we can test, and could decide later of the beeline testing scope - Added required dependencies to pom - Added specific results dir for beeline q.out-s Diffs (updated) ----- beeline/src/java/org/apache/hive/beeline/util/QFileClient.java 81f1b0e itests/qtest/src/test/java/org/apache/hadoop/hive/cli/DisabledTestBeeLineDriver.java cb276e6 itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java PRE-CREATION itests/src/test/resources/testconfiguration.properties 97e310d itests/util/pom.xml 6d93dc1 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 366c7b4 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java e5144e3 ql/src/test/results/clientpositive/beeline/escape_comments.q.out PRE-CREATION Diff: https://reviews.apache.org/r/52978/diff/ Testing ------- Manually on my computer several runs. Waiting for the QA tests Thanks, Peter Vary --===============3071567169680140131==--