hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <>
Subject Re: Review Request 52923: HIVE-14979 Removing stale Zookeeper locks at HiveServer2 initialization
Date Wed, 26 Oct 2016 15:24:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 26, 2016, 3:24 p.m.)

Review request for hive, Ashutosh Chauhan, Marta Kuczora, Miklos Csanady, namit jain, Sergio
Pena, and Barna Zsombor Klara.


Changed Zookeeper to ZooKeeper

Bugs: HIVE-14979

Repository: hive-git


Adding a new configuration option to HiveConf to signal whether stale lock removal is requested
on startup.
Adding a new method to ZooKeeperHiveLockManager to remove stale locks
Modifying the HiveServer2 to instantiate a lock manager and call the new method if defined
by the configuration.

Please take extra care when reviewing these:
- Modifying the lock fetching method to use the clientIp from the lock, and not update with
the current ip - Not sure why it was done before
- Instantiation of the lock manager - I might not chose the best method for it

Open for any suggestions :)


Diffs (updated)

  common/src/java/org/apache/hadoop/hive/conf/ 8ffae3b 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ 14d0ef4

  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ 3f9926e

  service/src/java/org/apache/hive/service/server/ 590b1f3 



Created 2 unit test cases:
- Removing own locks
- Not removing other server's locks

Manually tested the Lock manager instantiation method on HiveServer2


Peter Vary

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message