hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jianguo Tian <jianguo.t...@intel.com>
Subject Re: Review Request 52981: HIVE-14679: csv2/tsv2 output format disables quoting by default and it's difficult to enable
Date Fri, 21 Oct 2016 00:48:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52981/
-----------------------------------------------------------

(Updated Oct. 21, 2016, 12:48 a.m.)


Review request for hive and cheng xu.


Bugs: HIVE-14679
    https://issues.apache.org/jira/browse/HIVE-14679


Repository: hive-git


Description (updated)
-------

1. Enabled double quoting by default for csv2, tsv2 and dsv.
2. Disabling quoting using beeline argument --outputformat.
3. No quote character at all when disable quoting.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 79922d2 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 57b9c46 
  beeline/src/java/org/apache/hive/beeline/Commands.java 039e354 
  beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 66d9fd0 
  beeline/src/main/resources/BeeLine.properties ad79c01 
  beeline/src/test/org/apache/hive/beeline/TestOutputFormatWithQuotes.java PRE-CREATION 

Diff: https://reviews.apache.org/r/52981/diff/


Testing (updated)
-------

Ran JUnit test to validate csv2,tsv2,dsv,csv and tsv output format with enabling and disabling
double quotes.


Thanks,

Jianguo Tian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message