hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 52923: HIVE-14979 Removing stale Zookeeper locks at HiveServer2 initialization
Date Wed, 19 Oct 2016 11:50:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52923/
-----------------------------------------------------------

(Updated Oct. 19, 2016, 11:50 a.m.)


Review request for hive, Ashutosh Chauhan, Marta Kuczora, Miklos Csanady, namit jain, Sergio
Pena, and Barna Zsombor Klara.


Changes
-------

Addressed Lefty's comments


Bugs: HIVE-14979
    https://issues.apache.org/jira/browse/HIVE-14979


Repository: hive-git


Description
-------

Adding a new configuration option to HiveConf to signal whether stale lock removal is requested
on startup.
Adding a new method to ZooKeeperHiveLockManager to remove stale locks
Modifying the HiveServer2 to instantiate a lock manager and call the new method if defined
by the configuration.

Please take extra care when reviewing these:
- Modifying the lock fetching method to use the clientIp from the lock, and not update with
the current ip - Not sure why it was done before
- Instantiation of the lock manager - I might not chose the best method for it

Open for any suggestions :)

Thanks,
Peter


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8ffae3b 
  ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 14d0ef4

  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java 3f9926e

  service/src/java/org/apache/hive/service/server/HiveServer2.java 590b1f3 

Diff: https://reviews.apache.org/r/52923/diff/


Testing
-------

Created 2 unit test cases:
- Removing own locks
- Not removing other server's locks

Manually tested the Lock manager instantiation method on HiveServer2


Thanks,

Peter Vary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message