hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aihua Xu <...@cloudera.com>
Subject Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds
Date Fri, 14 Oct 2016 15:06:35 GMT


> On Oct. 14, 2016, 2:18 p.m., Yongzhi Chen wrote:
> > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java, line 231
> > <https://reviews.apache.org/r/52835/diff/2/?file=1535138#file1535138line231>
> >
> >     Is that possible a command has more than one lines?

Yes. It's possible. HiveSchemaHelper will normalize them into a single line. (Of course there
will be some limitation there but I haven't touched that logic there).


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52835/#review152674
-----------------------------------------------------------


On Oct. 13, 2016, 8:43 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52835/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 8:43 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java cd36ddf 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java 0d5f9c8

>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java 9c30ee7

> 
> Diff: https://reviews.apache.org/r/52835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message