hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zoltan Haindrich <k...@rxd.hu>
Subject Re: Review Request 52427: HIVE-14580 - Introduce || operator
Date Thu, 13 Oct 2016 20:14:45 GMT


> On Sept. 30, 2016, 5:30 p.m., pengcheng xiong wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g, line 434
> > <https://reviews.apache.org/r/52427/diff/1/?file=1516884#file1516884line434>
> >
> >     Could u test if the precedence is correct w.r.t the other DBMS? If you put it
here, it will be lower than */-, etc.
> 
> pengcheng xiong wrote:
>     Sorry, it should be "it will be the same as +- and lower than */, etc

putting it at the same level...is oracle-ish ;)

i've done some investigation about this...and i've changed my mind about its precedence ;)

patch#2 changes this: its below the | / & bitwise operators; and above the regular ops...i
think nobody want to do math with stringconcatenated numbers

details are in the ticket:
https://issues.apache.org/jira/browse/HIVE-14580?focusedCommentId=15546578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15546578


> On Sept. 30, 2016, 5:30 p.m., pengcheng xiong wrote:
> > ql/src/test/queries/clientpositive/concat_op.q, line 1
> > <https://reviews.apache.org/r/52427/diff/1/?file=1516886#file1516886line1>
> >
> >     Could you add more tests? For example, create views, joins, gby, union, || with
other operators, esp, |, *, +.

i've added some more testcases; it seems they work as expected


- Zoltan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52427/#review151046
-----------------------------------------------------------


On Oct. 13, 2016, 7:25 p.m., Zoltan Haindrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52427/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 7:25 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and pengcheng xiong.
> 
> 
> Bugs: HIVE-14580
>     https://issues.apache.org/jira/browse/HIVE-14580
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> adds support for || text concatenation
> 
> * reuses the concat udf for doing the real work
> * same precedence as + / - ; I think this is expected
> * small ast rewrite code in SemanticAnalyzer
> * details about other db || operators: https://issues.apache.org/jira/browse/HIVE-14580?focusedCommentId=15546578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15546578
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 025ea10cda5b126f46226809884088caadc0a3d0

>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 13f68796e4fe262098eaf6c5f09bc7f963d0f8cf

>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 747f3876b76de195fea78d87bfd98bd0ec2b87a0

>   ql/src/test/queries/clientpositive/concat_op.q PRE-CREATION 
>   ql/src/test/results/clientpositive/concat_op.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52427/diff/
> 
> 
> Testing
> -------
> 
> added qtest
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message