hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Illya Yalovyy <yalov...@amazon.com>
Subject Review Request 52487: HIVE-14875 Enhancement and refactoring of TestLdapAtnProviderWithMiniDS
Date Mon, 03 Oct 2016 17:38:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52487/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan, Chaoyu Tang, and Szehon Ho.


Repository: hive-git


Description
-------

This makes the following enhancements to defining the ldifs to apply
to the in-memory LDAP server:

* Extract defined ldifs to a resource file

* Remove unneeded attributes defined in each ldif entry such as:
  * sn (Surname) and givenName from group entries
  * distinguishedName from all entries as this attribute serves more
    as a parent type of many other attributes.

* Remove setting ExtensibleObject as an objectClass for all ldap entries
  as that is not needed. This objectClass would allow for adding any
  attribute to an entry.

* Add missing uid attribute to group entries whose dn refer to a uid
  attribute

* Add missing uidObject objectClass to entries that have the uid attribute

* Explicitly set organizationalPerson objectClass to user entries as
  they are using inetOrgPerson objectClass which is a subclass of
  the organizationalPerson objectClass

* Create indexes on cn and uid attributes as they are commonly
queried.

* Removed unused variables and imports.

* Fixed givenName for user3.

* Other minor code clean up.


Diffs
-----

  service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java 23a048a

  service/src/test/resources/ldap/example.com.ldif PRE-CREATION 

Diff: https://reviews.apache.org/r/52487/diff/


Testing
-------

Tests run: 126, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:00 min
[INFO] Finished at: 2016-09-29T21:20:04-07:00
[INFO] Final Memory: 40M/1000M
[INFO] ------------------------------------------------------------------------


Thanks,

Illya Yalovyy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message