Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0AA2C200BA0 for ; Fri, 30 Sep 2016 02:45:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 094C9160AE4; Fri, 30 Sep 2016 00:45:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 486E6160AE3 for ; Fri, 30 Sep 2016 02:45:52 +0200 (CEST) Received: (qmail 88106 invoked by uid 500); 30 Sep 2016 00:45:51 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88092 invoked by uid 99); 30 Sep 2016 00:45:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2016 00:45:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4F1BF2CACAE; Fri, 30 Sep 2016 00:45:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6727301314701100485==" MIME-Version: 1.0 Subject: Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2 From: Vihang Karajgaonkar To: Sergio Pena , Mohit Sabharwal Cc: Vihang Karajgaonkar , hive Date: Fri, 30 Sep 2016 00:45:50 -0000 Message-ID: <20160930004550.8246.70673@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vihang Karajgaonkar X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52283/ X-Sender: Vihang Karajgaonkar References: <20160928001548.30686.24017@reviews.apache.org> In-Reply-To: <20160928001548.30686.24017@reviews.apache.org> X-ReviewBoard-Diff-For: common/src/java/org/apache/hadoop/hive/common/EnvironmentUtils.java X-ReviewBoard-Diff-For: ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java Reply-To: Vihang Karajgaonkar X-ReviewRequest-Repository: hive-git archived-at: Fri, 30 Sep 2016 00:45:53 -0000 --===============6727301314701100485== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ ----------------------------------------------------------- (Updated Sept. 30, 2016, 12:45 a.m.) Review request for hive, Mohit Sabharwal and Sergio Pena. Changes ------- Added the credential provider support for distcp called from MoveTask Bugs: HIVE-14822 https://issues.apache.org/jira/browse/HIVE-14822 Repository: hive-git Description ------- This change adds support for credential provider for jobs launched from HiveServer2. It also adds support for job-specific credential provider and password which is passed to the jobs via the job configs when they are launched from HS2. The hive specific credential provider location is specified by a new configuration property specific to hiveserver2 and the password to job credential provider is provided using the environment variable Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/EnvironmentUtils.java PRE-CREATION common/src/java/org/apache/hadoop/hive/common/FileUtils.java 3ed2d086fd8e14b9a70550c02082c1456f905a08 common/src/java/org/apache/hadoop/hive/conf/Constants.java 77c6aa5663c2c5358715801bc039c0fe8035e3dc common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 43a16d7fed1d38400793e7c96a7febebe42d351b common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 16c2eafdb6888ed62168dd00f76335fa2484753b ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fd640567124e1bb8b558359732764a07c8b0f2ed ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java cea9582c8ccb0c79700ac7913735d4cdf52f0c7e ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java ce1106d91db9ef75e7b425d5950f888bacbfb3e5 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java 784b9c9fa769eeb088e3a6408a0b29147a8b4086 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java c75333d7022f776aab184a4b804fd7ad7befac64 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java a9f70c4100219c8929abd4e31b30d340e6ba98bd ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java PRE-CREATION spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing ------- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar --===============6727301314701100485==--