Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============6610084520230458756=="
MIME-Version: 1.0
Subject: Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider
 should be covered with unit tests
From: Illya Yalovyy <yalovyyi@amazon.com>
To: Ashutosh Chauhan <hashutosh@apache.org>, Szehon Ho <szehon@cloudera.com>,
 Naveen Gangam <ngangam@cloudera.com>, Chaoyu Tang <ctang.ma@gmail.com>
Cc: hive <dev@hive.apache.org>, Illya Yalovyy <yalovyyi@amazon.com>
Date: Wed, 21 Sep 2016 23:08:15 -0000
Message-ID: <20160921230815.1653.40669@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Illya Yalovyy <noreply@reviews.apache.org>
References: <20160917013658.31230.37752@reviews.apache.org>
In-Reply-To: <20160917013658.31230.37752@reviews.apache.org>
Reply-To: Illya Yalovyy <yalovyyi@amazon.com>
archived-at: Wed, 21 Sep 2016 23:08:23 -0000

--===============6610084520230458756==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote:
> > service/src/java/org/apache/hive/service/auth/ldap/Query.java, line 122
> > <https://reviews.apache.org/r/51694/diff/1/?file=1492949#file1492949line122>
> >
> >     Will it improve the performance to set the search limit? I did not see it is used.
> 
> Illya Yalovyy wrote:
>     I will be used for different filters. Do you think we should use it for existing filters? Which one in particular? Or you would prefer me to remove this option?
>     
>     Please keep in mind that this CR is not about performance.
> 
> Chaoyu Tang wrote:
>     I thought in the existing implementation, the search limits in some methods like findGroupDNByName, findUserDNByName are set to 2 to reduce the returned results in case there are many, is not it?

It does make sense. I'll make this change.


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51694/#review148634
-----------------------------------------------------------


On Sept. 20, 2016, 7:39 p.m., Illya Yalovyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51694/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 7:39 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Chaoyu Tang, Naveen Gangam, and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently LdapAuthenticationProviderImpl class is not covered with unit tests. To make this class testable some minor refactoring will be required.
> 
> 
> Diffs
> -----
> 
>   service/pom.xml ecea719 
>   service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java efd5393 
>   service/src/java/org/apache/hive/service/auth/ldap/ChainFilterFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/CustomQueryFilterFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/DirSearch.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/DirSearchFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/Filter.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/FilterFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/LdapSearch.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/LdapSearchFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/LdapUtils.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/Query.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/QueryFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/SearchResultHandler.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/UserFilterFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/UserSearchFilterFactory.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java 089a059 
>   service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java f276906 
>   service/src/test/org/apache/hive/service/auth/ldap/Credentials.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/LdapTestUtils.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestChainFilter.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestCustomQueryFilter.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestGroupFilter.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestLdapSearch.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestLdapUtils.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestQuery.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestQueryFactory.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestSearchResultHandler.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestUserFilter.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestUserSearchFilter.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51694/diff/
> 
> 
> Testing
> -------
> 
> ...hive/service> mvn clean test
> 
> ...
> 
> Results :
> 
> Tests run: 123, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 04:18 min
> [INFO] Finished at: 2016-09-06T08:46:04-07:00
> [INFO] Final Memory: 66M/984M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Illya Yalovyy
> 
>


--===============6610084520230458756==--