Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============0342779476790511417=="
MIME-Version: 1.0
Subject: Re: Review Request 51334: HIVE-14404: Allow delimiterfordsv to use
 multiple-character delimiters - second version
From: Gabor Szadovszky <gabor.szadovszky@cloudera.com>
To: Peter Vary <pvary@cloudera.com>, Sergio Pena <sergio.pena@cloudera.com>,
 Szehon Ho <szehon@cloudera.com>, Naveen Gangam <ngangam@cloudera.com>
Cc: hive <dev@hive.apache.org>,
 Gabor Szadovszky <gabor.szadovszky@cloudera.com>,
 Marta Kuczora <kuczoram@cloudera.com>
Date: Tue, 06 Sep 2016 13:25:40 -0000
Message-ID: <20160906132540.5210.27838@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Gabor Szadovszky <noreply@reviews.apache.org>
References: <20160906132150.5210.86857@reviews.apache.org>
In-Reply-To: <20160906132150.5210.86857@reviews.apache.org>
Reply-To: Gabor Szadovszky <gabor.szadovszky@cloudera.com>
archived-at: Tue, 06 Sep 2016 13:25:43 -0000

--===============0342779476790511417==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 6, 2016, 1:21 p.m., Gabor Szadovszky wrote:
> > LGTM
> 
> Marta Kuczora wrote:
>     Thanks a lot for the review by the way. I forgot to write it earlier. :)

You're very welcome. :)


- Gabor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51334/#review147822
-----------------------------------------------------------


On Sept. 6, 2016, 1:10 p.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51334/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 1:10 p.m.)
> 
> 
> Review request for hive, Naveen Gangam, Peter Vary, Sergio Pena, and Szehon Ho.
> 
> 
> Bugs: HIVE-14404
>     https://issues.apache.org/jira/browse/HIVE-14404
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed the class which is used to generate the output for the formats 'csv2', 'tsv2' and 'dsv' not to use SuperCSV any more and support multiple characters as delimiter.
> The class implements the same escaping logic as it had with SuperCSV if the quoting is not disabled.
> Extended the TestBeeLineWithArgs tests with new test steps which are using multiple characters as delimiter.
> 
> This review is a follow-up for the review 50896.
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml d03f770 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8e65e39 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 59fbca3 
>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 66d9fd0 
>   bin/beeline.cmd 971e20b 
>   bin/ext/beeline.sh 8052c45 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 1ca7623 
> 
> Diff: https://reviews.apache.org/r/51334/diff/
> 
> 
> Testing
> -------
> 
> - Tested manually in BeeLine.
> - Extended the TestBeeLineWithArgs tests with new test steps which are using multiple characters as delimiter.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>


--===============0342779476790511417==--