hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Vary <pv...@cloudera.com>
Subject Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some admission control mechanism for graceful degradation when resources are exhausted
Date Tue, 27 Sep 2016 08:02:46 GMT


> On Sept. 22, 2016, 3:21 p.m., Marta Kuczora wrote:
> > beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java, line
58
> > <https://reviews.apache.org/r/52122/diff/2/?file=1507972#file1507972line58>
> >
> >     Wouldn't it be better to split these checks into different test cases, so that
one test would contain only one check?

I was thinking about it, and decided to use only one test, since this is testing one switch
statement.
Does it make sense?


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52122/#review150014
-----------------------------------------------------------


On Sept. 22, 2016, 8:12 a.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52122/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 8:12 a.m.)
> 
> 
> Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, Vaibhav
Gumashta, Vihang Karajgaonkar, and Barna Zsombor Klara.
> 
> 
> Bugs: HIVE-9423
>     https://issues.apache.org/jira/browse/HIVE-9423
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adding different error message depending on the thrown TTransportException
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 5322ca6 
>   beeline/src/main/resources/BeeLine.properties 13321d2 
>   beeline/src/test/org/apache/hive/beeline/TestBeeLineExceptionHandling.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/52122/diff/
> 
> 
> Testing
> -------
> 
> Manual, and added unit test depending on the exception code
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message