hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jianguo Tian <jianguo.t...@intel.com>
Subject Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
Date Fri, 23 Sep 2016 05:26:13 GMT


> On Sept. 23, 2016, 2:52 a.m., cheng xu wrote:
> > jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java, line 74
> > <https://reviews.apache.org/r/51695/diff/5/?file=1507938#file1507938line74>
> >
> >     You can change the expected variable as an array.And use the following to check
equality:
> >           assertTrue(ArrayUtils.isEquals())

As method parseInitFile() return a List type, it's difficult to check equality with assertTrue(ArrayUtils.isEquals()).
Besides, it looks that initializing expected as an array won't work, I have tried it.


- Jianguo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51695/#review150122
-----------------------------------------------------------


On Sept. 22, 2016, 6:49 a.m., Jianguo Tian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51695/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 6:49 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Bugs: HIVE-5867
>     https://issues.apache.org/jira/browse/HIVE-5867
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ad96a6466dd1aadab71fc261f55be4639dcbe2bf

>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 3161566994d6c6e01de9d88a6e87295684619ffa

>   jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51695/diff/
> 
> 
> Testing
> -------
> 
> TestRunInitialSQL.java is a JUnit test class which can test parseInitFile() method of
HiveConnection.java. I test some positive cases and negative cases to look that if these cases
could be parse into SQL statement which could be executed successfully.
> 
> 
> Thanks,
> 
> Jianguo Tian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message