hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cheng xu <cheng.a...@intel.com>
Subject Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
Date Fri, 23 Sep 2016 02:52:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51695/#review150122
-----------------------------------------------------------




jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 18)
<https://reviews.apache.org/r/51695/#comment217997>

    Break line here please.



jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 53)
<https://reviews.apache.org/r/51695/#comment217991>

    This should a comment, right?
    e.g. //The cases above are some positive cases which could be executed. Here are some
negative cases as below



jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 67)
<https://reviews.apache.org/r/51695/#comment217993>

    Can we do this one time setup in @BeforeClass method?



jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 74)
<https://reviews.apache.org/r/51695/#comment217996>

    You can change the expected variable as an array.And use the following to check equality:
          assertTrue(ArrayUtils.isEquals())



jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java (line 81)
<https://reviews.apache.org/r/51695/#comment217992>

    Can we do this one time clean up in @AfterClass method?


- cheng xu


On Sept. 22, 2016, 2:49 p.m., Jianguo Tian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51695/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 2:49 p.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Bugs: HIVE-5867
>     https://issues.apache.org/jira/browse/HIVE-5867
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ad96a6466dd1aadab71fc261f55be4639dcbe2bf

>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 3161566994d6c6e01de9d88a6e87295684619ffa

>   jdbc/src/test/org/apache/hive/jdbc/TestRunInitialSQL.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51695/diff/
> 
> 
> Testing
> -------
> 
> TestRunInitialSQL.java is a JUnit test class which can test parseInitFile() method of
HiveConnection.java. I test some positive cases and negative cases to look that if these cases
could be parse into SQL statement which could be executed successfully.
> 
> 
> Thanks,
> 
> Jianguo Tian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message