hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Illya Yalovyy <yalov...@amazon.com>
Subject Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests
Date Wed, 21 Sep 2016 23:10:51 GMT


> On Sept. 21, 2016, 12:50 a.m., Szehon Ho wrote:
> > This looks like a great refactoring to me. This class was always hard to understand,
and this makes it a little easier.  I'll defer to Chaoyu to the comments.

Thank you!


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51694/#review149769
-----------------------------------------------------------


On Sept. 20, 2016, 7:39 p.m., Illya Yalovyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51694/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 7:39 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Chaoyu Tang, Naveen Gangam, and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently LdapAuthenticationProviderImpl class is not covered with unit tests. To make
this class testable some minor refactoring will be required.
> 
> 
> Diffs
> -----
> 
>   service/pom.xml ecea719 
>   service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java efd5393

>   service/src/java/org/apache/hive/service/auth/ldap/ChainFilterFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/CustomQueryFilterFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/DirSearch.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/DirSearchFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/Filter.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/FilterFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/LdapSearch.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/LdapSearchFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/LdapUtils.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/Query.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/QueryFactory.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/auth/ldap/SearchResultHandler.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/UserFilterFactory.java PRE-CREATION

>   service/src/java/org/apache/hive/service/auth/ldap/UserSearchFilterFactory.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java 089a059

>   service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java
f276906 
>   service/src/test/org/apache/hive/service/auth/ldap/Credentials.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/LdapTestUtils.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestChainFilter.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestCustomQueryFilter.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestGroupFilter.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestLdapSearch.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestLdapUtils.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestQuery.java PRE-CREATION 
>   service/src/test/org/apache/hive/service/auth/ldap/TestQueryFactory.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestSearchResultHandler.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestUserFilter.java PRE-CREATION

>   service/src/test/org/apache/hive/service/auth/ldap/TestUserSearchFilter.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/51694/diff/
> 
> 
> Testing
> -------
> 
> ...hive/service> mvn clean test
> 
> ...
> 
> Results :
> 
> Tests run: 123, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 04:18 min
> [INFO] Finished at: 2016-09-06T08:46:04-07:00
> [INFO] Final Memory: 66M/984M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Illya Yalovyy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message