hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jianguo Tian <jianguo.t...@intel.com>
Subject Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
Date Wed, 14 Sep 2016 04:54:26 GMT


> On Sept. 13, 2016, 2:52 a.m., Vihang Karajgaonkar wrote:
> > Can you please tell us how is this different than -i or --init option in the Beeline?

HIVE-5867 includes two parts of job, one is for Beeline, the other is for JDBC. And they both
aim to support executing an initial SQL file, but Beeline has already support this function,
whereas JDBC doesn't. So what I'm doing now is complete this function of JDBC.
The pattern of transmitting initial SQl file is diffrent, when build JDBC connection like
"jdbc:hive2://localhost:10000/default;initScript=/home/user1/scripts/init.sql", but Beeline
is "-i". So we need to separate them into two parts, although they look like in almost same
logic.


- Jianguo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51695/#review148639
-----------------------------------------------------------


On Sept. 13, 2016, 2:36 a.m., Jianguo Tian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51695/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 2:36 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Bugs: HIVE-5867
>     https://issues.apache.org/jira/browse/HIVE-5867
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ad96a6466dd1aadab71fc261f55be4639dcbe2bf

>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 3161566994d6c6e01de9d88a6e87295684619ffa

>   jdbc/src/test/org/apache/hive/jdbc/TestInitSQL.java PRE-CREATION 
>   jdbc/src/test/resources/init.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51695/diff/
> 
> 
> Testing
> -------
> 
> TestInitSQL.java is JUnit test class which will test method initSql() in HiveConnection.java.
> 
> 
> Thanks,
> 
> Jianguo Tian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message