hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cheng xu <cheng.a...@intel.com>
Subject Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
Date Thu, 08 Sep 2016 01:13:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51695/#review148124
-----------------------------------------------------------




jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 128)
<https://reviews.apache.org/r/51695/#comment215548>

    Extra Space



jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 150)
<https://reviews.apache.org/r/51695/#comment215549>

    Extra Space



jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 160)
<https://reviews.apache.org/r/51695/#comment215550>

    Extra Space



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 116)
<https://reviews.apache.org/r/51695/#comment215552>

    2 space indent from L116 to L166



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 127)
<https://reviews.apache.org/r/51695/#comment215557>

    Will this handle the following case?
    {noformat}
    show
     tables;
    {noformat}



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 136)
<https://reviews.apache.org/r/51695/#comment215564>

    Can we move it to the finally block?



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 147)
<https://reviews.apache.org/r/51695/#comment215559>

    LOG.error



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 154)
<https://reviews.apache.org/r/51695/#comment215558>

    Remove this line.



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 156)
<https://reviews.apache.org/r/51695/#comment215553>

    Extra space



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 159)
<https://reviews.apache.org/r/51695/#comment215554>

    Extra space



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 161)
<https://reviews.apache.org/r/51695/#comment215555>

    Extra space



jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java (line 167)
<https://reviews.apache.org/r/51695/#comment215560>

    No ident needed here.



jdbc/src/test/org/apache/hive/jdbc/TestHiveDriver.java (line 14)
<https://reviews.apache.org/r/51695/#comment215562>

    Can this test pass without starting any server?



jdbc/src/test/org/apache/hive/jdbc/TestHiveDriver.java (line 19)
<https://reviews.apache.org/r/51695/#comment215561>

    Extra space.



jdbc/src/test/resources/init.sql (line 3)
<https://reviews.apache.org/r/51695/#comment215563>

    Remove this line since it's commented out.


- cheng xu


On Sept. 8, 2016, 8:52 a.m., Jianguo Tian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51695/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 8:52 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Bugs: HIVE-5867
>     https://issues.apache.org/jira/browse/HIVE-5867
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5867: JDBC driver and beeline should support executing an initial SQL script
> 
> 
> Diffs
> -----
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ad96a6466dd1aadab71fc261f55be4639dcbe2bf

>   jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8bdad09f526f66a71768ecd2ca019671167

>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 3161566994d6c6e01de9d88a6e87295684619ffa

>   jdbc/src/test/org/apache/hive/jdbc/TestHiveDriver.java PRE-CREATION 
>   jdbc/src/test/resources/init.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51695/diff/
> 
> 
> Testing
> -------
> 
> TestHiveDriver.java is JUnit test class which will print the rusult of executing initial
SQL(init.sql locate in src/test/resources).
> 
> 
> Thanks,
> 
> Jianguo Tian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message