hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zoltan Haindrich <k...@rxd.hu>
Subject Re: Review Request 51568: HIVE-13555 add nullif
Date Thu, 01 Sep 2016 23:30:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51568/
-----------------------------------------------------------

(Updated Sept. 1, 2016, 11:30 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

more strict argument checking


Bugs: HIVE-13555
    https://issues.apache.org/jira/browse/HIVE-13555


Repository: hive-git


Description (updated)
-------

* adds nullif(a,b) udf
* argument converion is is bounded to not convert between different types


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 69a18cd3b4e383f5f7eb9b8cbffd133b13b5a595

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNullif.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNullif.java PRE-CREATION

  ql/src/test/queries/clientpositive/udf_nullif.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 68c24a6fc108cb30253b5ca462e5d4680e58b84a

  ql/src/test/results/clientpositive/udf_nullif.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/51568/diff/


Testing
-------

addedd some unit cases + qtest


Thanks,

Zoltan Haindrich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message