Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ADB22200B76 for ; Tue, 30 Aug 2016 08:34:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AC076160ABA; Tue, 30 Aug 2016 06:34:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F206E160AA8 for ; Tue, 30 Aug 2016 08:34:50 +0200 (CEST) Received: (qmail 58262 invoked by uid 500); 30 Aug 2016 06:34:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 58239 invoked by uid 99); 30 Aug 2016 06:34:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2016 06:34:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0887F2CFDB1; Tue, 30 Aug 2016 06:34:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0059102976255601765==" MIME-Version: 1.0 Subject: Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat From: Peter Vary To: Barna Zsombor Klara , Sergio Pena , Gabor Szadovszky , Chaoyu Tang Cc: Peter Vary , hive Date: Tue, 30 Aug 2016 06:34:47 -0000 Message-ID: <20160830063447.17564.86232@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Peter Vary X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51435/ X-Sender: Peter Vary References: <20160825203603.2089.56072@reviews.apache.org> In-Reply-To: <20160825203603.2089.56072@reviews.apache.org> Reply-To: Peter Vary X-ReviewRequest-Repository: hive-git archived-at: Tue, 30 Aug 2016 06:34:51 -0000 --===============0059102976255601765== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/ ----------------------------------------------------------- (Updated Aug. 30, 2016, 6:34 a.m.) Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and Barna Zsombor Klara. Bugs: HIVE-14426 https://issues.apache.org/jira/browse/HIVE-14426 Repository: hive-git Description ------- Used HiveConf.stripHiddenConfigurations to remove sensitive information from configuration dump. Had to refactor, so it could be applied to simple Configuration objects too, like AppConfig. Used Utilities.maskIfPassword to remove sensitive information from property dump Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 14a538b common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 073a978 hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java dd1208b hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java 201e647 Diff: https://reviews.apache.org/r/51435/diff/ Testing ------- Manually - checked both Thanks, Peter Vary --===============0059102976255601765==--