Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BBDF0200B6D for ; Tue, 23 Aug 2016 09:19:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BA876160AAD; Tue, 23 Aug 2016 07:19:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0BBA1160AA5 for ; Tue, 23 Aug 2016 09:19:08 +0200 (CEST) Received: (qmail 30615 invoked by uid 500); 23 Aug 2016 07:19:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 30596 invoked by uid 99); 23 Aug 2016 07:19:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Aug 2016 07:19:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08BA31DD20B; Tue, 23 Aug 2016 07:19:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2314115991684264994==" MIME-Version: 1.0 Subject: Re: Review Request 51287: The ConsoleReader.readLine method never echoes back the executed line. Instead, Beeline.info is used, which is redirected to stderr with other messages. On interactive mode both outputs are visible. From: Miklos Csanady To: Vihang Karajgaonkar , Sergio Pena , Peter Vary Cc: hive , Miklos Csanady Date: Tue, 23 Aug 2016 07:19:06 -0000 Message-ID: <20160823071906.2089.74023@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Miklos Csanady X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51287/ X-Sender: Miklos Csanady References: <20160823003433.2089.12738@reviews.apache.org> In-Reply-To: <20160823003433.2089.12738@reviews.apache.org> Reply-To: Miklos Csanady X-ReviewRequest-Repository: hive-git archived-at: Tue, 23 Aug 2016 07:19:09 -0000 --===============2314115991684264994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 23, 2016, 12:34 a.m., Sergio Pena wrote: > > Could you paste the test you made for this patch? like before & after the patch output? I have discovered that it breaks some of the tests in org.apache.beeline.cli.TestHiveCli.java. Now I try to investigate this and modify them if it seems to be the best solution. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51287/#review146463 ----------------------------------------------------------- On Aug. 22, 2016, 5:40 p.m., Miklos Csanady wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51287/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 5:40 p.m.) > > > Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-14525 > https://issues.apache.org/jira/browse/HIVE-14525 > > > Repository: hive-git > > > Description > ------- > > HIVE-14525: beeline still writing log data to stdout as of version 2.1.0 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java e0fa032 > > Diff: https://reviews.apache.org/r/51287/diff/ > > > Testing > ------- > > Beeline with redirected input and output with script file and without one. > > > Thanks, > > Miklos Csanady > > --===============2314115991684264994==--