hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 51542: HIVE-14652 incorrect results for not in on partition columns
Date Wed, 31 Aug 2016 18:31:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51542/#review147456
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java (line 286)
<https://reviews.apache.org/r/51542/#comment214641>

    Will STRUCT with all constants inside e.g. (x, y) in (1,2), be handled correctly by this
code block? In that case, (1, 2) should be considered a constant, thus we could remove the
IN. However, I think currently we will end up with UNKNOWN state and we will never remove
it. I think that was a case that we were supporting previously, thus it would be a regression.
Could you double check?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java (line 374)
<https://reviews.apache.org/r/51542/#comment214635>

    WalkState.CONSTANT or WalkState.UNKNOWN? (I think in this case it should be the latest)


- Jesús Camacho Rodríguez


On Aug. 30, 2016, 9:56 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51542/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 9:56 p.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java f9388e2

>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java b2125ca 
>   ql/src/test/queries/clientpositive/partition_condition_remover.q PRE-CREATION 
>   ql/src/test/results/clientpositive/partition_condition_remover.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/pcs.q.out 0045c1c 
> 
> Diff: https://reviews.apache.org/r/51542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message