hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chaoyu Tang <ctang...@gmail.com>
Subject Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat
Date Wed, 31 Aug 2016 16:02:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51435/#review147447
-----------------------------------------------------------


Ship it!




LGTM

- Chaoyu Tang


On Aug. 31, 2016, 3:32 p.m., Peter Vary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51435/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 3:32 p.m.)
> 
> 
> Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and Barna Zsombor
Klara.
> 
> 
> Bugs: HIVE-14426
>     https://issues.apache.org/jira/browse/HIVE-14426
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Used HiveConf.stripHiddenConfigurations to remove sensitive information from configuration
dump. Had to refactor, so it could be applied to simple Configuration objects too, like AppConfig.
> 
> Used Utilities.maskIfPassword to remove sensitive information from property dump
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/LogUtils.java 599e798 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 14a538b 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 073a978 
>   common/src/test/org/apache/hadoop/hive/common/TestLogUtils.java PRE-CREATION 
>   hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java
dd1208b 
>   hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java
201e647 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java a542dc4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java ac922ce 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java 8e5c0da

>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 0786f9b 
> 
> Diff: https://reviews.apache.org/r/51435/diff/
> 
> 
> Testing
> -------
> 
> Manually - checked both
> 
> 
> Thanks,
> 
> Peter Vary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message