hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gabor Szadovszky <gabor.szadovs...@cloudera.com>
Subject Re: Review Request 51381: HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns
Date Thu, 25 Aug 2016 23:47:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51381/#review146886
-----------------------------------------------------------



Some minor findings/questions. LGTM, otherwise.


metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java (line 370)
<https://reviews.apache.org/r/51381/#comment213661>

    As you are already using StringBuilder, I would suggest using .append(...) instead of
'+'.



metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java (line 384)
<https://reviews.apache.org/r/51381/#comment213665>

    Is an int enough for this sum of ints?



metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java (line 412)
<https://reviews.apache.org/r/51381/#comment213666>

    Not sure what would be the maximum number of rows. Is int enough?



metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java (line 501)
<https://reviews.apache.org/r/51381/#comment213669>

    Is there a missing string to be added? I don't think it make sense to add an empty one...


- Gabor Szadovszky


On Aug. 24, 2016, 6:06 p.m., Barna Zsombor Klara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51381/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 6:06 p.m.)
> 
> 
> Review request for hive and Eugene Koifman.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java 75a4d875562f9ec85d2d02e36526de8b1e0c4404

>   ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java f513d0fa791f24da4ce6312df9923db692ef7129

> 
> Diff: https://reviews.apache.org/r/51381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message